From dd5acac9147ee4e7a5b90f26953c19497626b945 Mon Sep 17 00:00:00 2001 From: Samo Penic <samo.penic@fe.uni-lj.si> Date: Wed, 30 Apr 2014 12:13:24 +0000 Subject: [PATCH] Debugged so it does not segfaults. It seems it keeps volume constant in one timestep, but it fails to do so after inner loop. --- src/vertexmove.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 48 insertions(+), 6 deletions(-) diff --git a/src/vertexmove.c b/src/vertexmove.c index 6bc730e..cecb73e 100644 --- a/src/vertexmove.c +++ b/src/vertexmove.c @@ -9,19 +9,21 @@ #include "timestep.h" #include "cell.h" //#include "io.h" +#include "io.h" #include<stdio.h> #include "vertexmove.h" #include <string.h> +#include "constvol.h" ts_bool single_verticle_timestep(ts_vesicle *vesicle,ts_vertex *vtx,ts_double *rn){ ts_uint i; ts_double dist; ts_bool retval; ts_uint cellidx; - ts_double delta_energy,oenergy,dvol=0.0; + ts_double delta_energy, delta_energy_cv,oenergy,dvol=0.0; ts_double costheta,sintheta,phi,r; //This will hold all the information of vtx and its neighbours - ts_vertex backupvtx[20]; + ts_vertex backupvtx[20], *constvol_vtx_moved=NULL, *constvol_vtx_backup=NULL; memcpy((void *)&backupvtx[0],(void *)vtx,sizeof(ts_vertex)); //Some stupid tests for debugging cell occupation! @@ -90,11 +92,15 @@ memcpy((void *)&backupvtx[i+1],(void *)vtx->neigh[i],sizeof(ts_vertex)); } - if(vesicle->pswitch == 1){ + if(vesicle->pswitch == 1 || vesicle->tape->constvolswitch==1){ for(i=0;i<vtx->tristar_no;i++) dvol-=vtx->tristar[i]->volume; }; delta_energy=0; + +// vesicle_volume(vesicle); +// fprintf(stderr,"Volume in the beginning=%1.16e\n", vesicle->volume); + //update the normals of triangles that share bead i. for(i=0;i<vtx->tristar_no;i++) triangle_normal_vector(vtx->tristar[i]); oenergy=vtx->energy; @@ -107,11 +113,32 @@ delta_energy+=vtx->neigh[i]->xk*(vtx->neigh[i]->energy-oenergy); } - if(vesicle->pswitch == 1){ + if(vesicle->pswitch == 1 || vesicle->tape->constvolswitch == 1){ for(i=0;i<vtx->tristar_no;i++) dvol+=vtx->tristar[i]->volume; - delta_energy-=vesicle->pressure*dvol; + if(vesicle->pswitch==1) delta_energy-=vesicle->pressure*dvol; }; +// vesicle_volume(vesicle); +// fprintf(stderr,"Volume before=%1.16e\n", vesicle->volume); + if(vesicle->tape->constvolswitch == 1){ + retval=constvolume(vesicle, vtx, -dvol, &delta_energy_cv, &constvol_vtx_moved,&constvol_vtx_backup); + if(retval==TS_FAIL){ // if we couldn't move the vertex to assure constant volume + vtx=memcpy((void *)vtx,(void *)&backupvtx[0],sizeof(ts_vertex)); + for(i=0;i<vtx->neigh_no;i++){ + vtx->neigh[i]=memcpy((void *)vtx->neigh[i],(void *)&backupvtx[i+1],sizeof(ts_vertex)); + } + for(i=0;i<vtx->tristar_no;i++) triangle_normal_vector(vtx->tristar[i]); + // fprintf(stderr,"fajlam!\n"); + return TS_FAIL; + } +// vesicle_volume(vesicle); +// fprintf(stderr,"Volume after=%1.16e\n", vesicle->volume); +// fprintf(stderr,"Volume after-dvol=%1.16e\n", vesicle->volume-dvol); +// fprintf(stderr,"Denergy before=%e\n",delta_energy); + + delta_energy+=delta_energy_cv; +// fprintf(stderr,"Denergy after=%e\n",delta_energy); + } /* No poly-bond energy for now! if(vtx->grafted_poly!=NULL){ delta_energy+= @@ -133,6 +160,7 @@ #endif { //not accepted, reverting changes + // fprintf(stderr,"MC failed\n"); vtx=memcpy((void *)vtx,(void *)&backupvtx[0],sizeof(ts_vertex)); for(i=0;i<vtx->neigh_no;i++){ vtx->neigh[i]=memcpy((void *)vtx->neigh[i],(void *)&backupvtx[i+1],sizeof(ts_vertex)); @@ -141,10 +169,18 @@ //update the normals of triangles that share bead i. for(i=0;i<vtx->tristar_no;i++) triangle_normal_vector(vtx->tristar[i]); +// fprintf(stderr, "before vtx(x,y,z)=%e,%e,%e\n",constvol_vtx_moved->x, constvol_vtx_moved->y, constvol_vtx_moved->z); + if(vesicle->tape->constvolswitch == 1){ + constvolumerestore(constvol_vtx_moved,constvol_vtx_backup); + } +// fprintf(stderr, "after vtx(x,y,z)=%e,%e,%e\n",constvol_vtx_moved->x, constvol_vtx_moved->y, constvol_vtx_moved->z); +// vesicle_volume(vesicle); +// fprintf(stderr,"Volume after fail=%1.16e\n", vesicle->volume); return TS_FAIL; } } - + //accepted + // fprintf(stderr,"MC accepted\n"); // oldcellidx=vertex_self_avoidance(vesicle, &backupvtx[0]); if(vtx->cell!=vesicle->clist->cell[cellidx]){ retval=cell_add_vertex(vesicle->clist->cell[cellidx],vtx); @@ -152,8 +188,14 @@ if(retval==TS_SUCCESS) cell_remove_vertex(backupvtx[0].cell,vtx); } + + if(vesicle->tape->constvolswitch == 1){ + constvolumeaccept(vesicle,constvol_vtx_moved,constvol_vtx_backup); + } // if(oldcellidx); //END MONTE CARLOOOOOOO +// vesicle_volume(vesicle); +// fprintf(stderr,"Volume after success=%1.16e\n", vesicle->volume); return TS_SUCCESS; } -- Gitblit v1.9.3