From bd826de2f539f2e48c8c01d2d7f9f34c7e97104a Mon Sep 17 00:00:00 2001 From: Samo Penic <samo.penic@gmail.com> Date: Fri, 13 May 2016 07:43:27 +0000 Subject: [PATCH] Fix in trisurf output, inhibiting print of successful reconstruction. Multiple fixes and improvements in python module. Added symlinking of tapes into the running directories and dumping tapes from snapshots into tape files. --- python/trisurf/trisurf.py | 226 +++++++++++++++++++++++++++++++++++++++++++++++++------- 1 files changed, 198 insertions(+), 28 deletions(-) diff --git a/python/trisurf/trisurf.py b/python/trisurf/trisurf.py index bf0809e..9018555 100644 --- a/python/trisurf/trisurf.py +++ b/python/trisurf/trisurf.py @@ -9,26 +9,77 @@ from itertools import islice import mmap import shlex -''' -This is a trisurf instance manager written in python +import psutil +import time +import datetime +import subprocess + +# Process status +TS_NOLOCK=0 # lock file does not exist +TS_NONEXISTANT=0 # process is not in the list of processes +TS_STOPPED=1 # the process is listed, but is in stopped state +TS_RUNNING=2 # process is running + +class FileContent: + ''' + Class is helpful for reading and writting the specific files. + ''' + def __init__(self,filename): + ''' The instance is done by calling constructor FileContent(filename) + + The object then reads filename if it exists, otherwise the data is empty string. + User may force to reread file by calling the readline() method of the class. + + Filename is stored in local variable for future file operations. + ''' + + self.filename=filename + self.readfile() + + def readfile(self): + '''Force reread of the file and setting the data''' + self.data="" + try: + with open (self.filename, "r") as myfile: + self.data=myfile.read().replace('\n', '') #read the file and remove newline from the text + except: + pass # does nothing if error occurs -Invoke with: -tsmgr [-t tape | -r snapshot.vtu] [-s subdirectory] + def writefile(self, data, mode='w'): + '''File may be updated by completely rewritting the file contents or appending the data to the end of the file. + this is achieved by calling writefile(data, mode) method, where data is the string data to be written and + mode can be 'a' for append and 'w' for writting the file anew. + ''' + with open (self.filename, mode) as myfile: + myfile.write(data) -If tape is specified, the trisurf wilt start from tape with initial distribution, if snapshot is specified the trisurf will be restored from given snapshot file and simulation will continue. + def getText(self): + ''' + Method getText() or calling the object itself returns string of data + ''' + return self.data -''' - - + def __str__(self): + ''' + Method getText() or calling the object itself returns string of data + ''' + return self.getText() class Tape: - '''Has all the info on the tape''' + ''' + Special class that manages configuration of trisurf (commonly named tape). It can read and parse configuration from disk or parse it from string. + ''' def __init__(self): + '''The object is instatiated by calling Tape() constructor without parameters''' return def readTape(self, tape='tape'): + ''' + Tape is read and parsed by calling the readTape() method with optional tape parameter, which is full path to filename where the configuration is stored. + If the tape cannot be read, it prints error and exits. + ''' try: self.config=configobj.ConfigObj(tape) except: @@ -36,13 +87,17 @@ exit(1) def setTape(self, string): + '''Method setTape(string) parses the string in memory that hold the tape contents.''' self.config=configobj.ConfigObj(io.StringIO(string)) return def getValue(self,key): + '''Method getValue(key) returns value of a single parsed setting named "key".''' + return self.config[key] def __str__(self): + '''Calling the object itself, it recreates the tape contents from parsed values in form of key=value.''' retval="" for key,val in self.config.iteritems(): retval=retval+str(key)+" = "+str(val)+"\n" @@ -51,22 +106,31 @@ class Directory: + ''' + Class deals with the paths where the simulation is run and data is stored. + ''' def __init__(self, maindir=".", simdir=""): + '''Initialization Directory() takes two optional parameters, namely maindir and simdir. Defaults to current directory. It sets local variables maindir and simdir accordingly.''' self.maindir=maindir self.simdir=simdir return def fullpath(self): + ''' + Method returns string of path where the data is stored. It combines values of maindir and simdir as maindir/simdir on Unix. + ''' return os.path.join(self.maindir,self.simdir) def exists(self): + ''' Method checks whether the directory specified by fullpath() exists. It return True/False on completion.''' path=self.fullpath() if(os.path.exists(path)): - return 1 + return True else: - return 0 + return False def make(self): + ''' Method make() creates directory. If it fails it exits the program with error message.''' try: os.makedirs(self.fullpath()) except: @@ -75,11 +139,15 @@ return def makeifnotexist(self): + '''Method makeifnotexist() creates directory if it does not exist.''' if(self.exists()==0): self.make() - return + return True + else: + return False def remove(self): + '''Method remove() removes directory recursively. WARNING! No questions asked.''' if(self.exists()): try: os.rmdir(self.fullpath()) @@ -89,6 +157,9 @@ return def goto(self): + ''' + Method goto() moves current directory to the one specified by fullpath(). WARNING: when using the relative paths, do not call this function multiple times. + ''' try: os.chdir(self.fullpath()) except: @@ -97,23 +168,34 @@ class Statistics: + ''' + Class that deals with the statistics file from the simulations. + File is generally large and not all data is needed, so it is dealt with in a specific way. + ''' + def __init__(self,path,filename="statistics.csv"): + ''' + At the initialization call it receives optional filename parameter specifying the path and filename of the statistics file. + + The local variables path, filename, fullname (joined path and filename) and private check if the file exists are stored. + ''' self.path=path self.filename=filename self.fullname=os.path.join(path,filename) - self.read() + self.fileOK=self.read() return - def __str__(self): - return(str(self.fullname)) - def exists(self): + '''Method check if the statistics file exists.''' if(os.path.isfile(self.fullname)): return True else: return False def mapcount(self): + ''' + Internal method for determining the number of the lines in the most efficient way. Is it really the most efficient? + ''' f = open(self.fullname, "r+") buf = mmap.mmap(f.fileno(), 0) lines = 0 @@ -123,6 +205,9 @@ return lines def read(self): + ''' + Method read() reads the statistics if it exists. It sets local variable dT storing the time differential between two intervals of simulation (outer loops). It also stores last simulation loop and the start of the run. + ''' if(self.exists()): nlines=self.mapcount() try: @@ -140,25 +225,36 @@ n2=fields[1] i=i+1 except: - print("Cannot read statistics file in "+self.fullname+"\n") + #print("Cannot read statistics file in "+self.fullname+"\n") return(False) else: - print("File "+self.fullname+" does not exists.\n") + #print("File "+self.fullname+" does not exists.\n") return(False) self.dT=(int(epoch2)-int(epoch1))/(int(n2)-int(n1)) + self.last=n2 + self.startDate=epoch1 return(True) + + def __str__(self): + ''' + Prints the full path with filename of the statistics.csv file + ''' + return(str(self.fullname)) + class Runner: ''' - Class Runner consists of a single running or terminated instance of the trisurf + Class Runner consists of a single running or terminated instance of the trisurf. It manages starting, stopping, verifying the running process and printing the reports of the configured instances. ''' - def __init__(self, subdir='run0', tape='', snapshot=''): + def __init__(self, subdir='run0', tape=None, snapshot=None, runArgs=[]): self.subdir=subdir - if(tape!=''): + self.runArgs=runArgs + self.fromSnapshot=False + if(tape!=None): self.initFromTape(tape) - if(snapshot!=''): + if(snapshot!=None): self.initFromSnapshot(snapshot) return @@ -166,6 +262,7 @@ def initFromTape(self, tape): self.tape=Tape() self.tape.readTape(tape) + self.tapeFile=tape def initFromSnapshot(self, snapshotfile): try: @@ -173,22 +270,74 @@ except: print("Error reading snapshot file") exit(1) - + self.fromSnapshot=True + self.snapshotFile=snapshotfile root = tree.getroot() tapetxt=root.find('tape') version=root.find('trisurfversion') self.tape=Tape() self.tape.setTape(tapetxt.text) + + def getPID(self): + self.Dir=Directory(maindir=self.maindir,simdir=self.subdir) + #self.Dir.makeifnotexist() + try: + fp = open(os.path.join(self.Dir.fullpath(),'.lock')) + except IOError as e: + return 0 #file probably does not exist. e==2?? + pid=fp.readline() + fp.close() + return int(pid) def getStatus(self): - return 0 + pid=self.getPID() + if(pid==0): + return TS_NOLOCK + if(psutil.pid_exists(int(pid))): + proc= psutil.Process(int(pid)) + if proc.name()=="trisurf": + if proc.status()=="stopped": + return TS_STOPPED + else: + return TS_RUNNING + else: + return TS_NONEXISTANT + else: + return TS_NONEXISTANT def start(self): if(self.getStatus()==0): self.Dir=Directory(maindir=self.maindir,simdir=self.subdir) - self.Dir.makeifnotexist() +#Symlinks tape file to the directory or create tape file from snapshot in the direcory... + if(self.Dir.makeifnotexist()): + if(self.fromSnapshot==False): + try: + os.symlink(os.path.abspath(self.tapeFile), self.Dir.fullpath()+"/tape") + except: + print("Error while symlinking "+os.path.abspath(self.tapeFile)+" to "+self.Dir.fullpath()+"/tape") + exit(1) + else: + try: + with open (os.path.join(self.Dir.fullpath(),"tape"), "w") as myfile: + myfile.write("#This is automatically generated tape file from snapshot\n") + myfile.write(str(self.tape)) + except: + print("Error -- cannot make tapefile "+ os.path.join(self.Dir.fullpath(),"tape")+" from the snapshot in the running directory") + exit(1) + try: + os.symlink(os.path.abspath(self.snapshotFile), os.path.join(self.Dir.fullpath(),self.snapshotFile)) + except: + print("Error while symlinking "+os.path.abspath(self.snapshotFile)+" to "+os.path.join(self.Dir.fullpath(),self.snapshotFile)) + + cwd=Directory(maindir=os.getcwd()) self.Dir.goto() print("Starting trisurf-ng executable at "+self.Dir.fullpath()+"\n") + if(self.fromSnapshot==True): + params=["trisurf", "--restore-from-vtk",self.snapshotFile]+self.runArgs + else: + params=["trisurf"]+self.runArgs + subprocess.Popen (params, stdout=subprocess.DEVNULL) + cwd.goto() else: print("Process already running. Not starting\n") return @@ -197,7 +346,7 @@ pass def setMaindir(self,prefix,variables): - maindir="./" + maindir="" for p,v in zip(prefix,variables): if(v=="xk0"): tv=str(round(float(self.tape.config[v]))) @@ -212,8 +361,29 @@ return def getStatistics(self, statfile="statistics.csv"): - self.statistics=Statistics("", statfile) # we are already in the running directory, so local path is needed! - return + self.Dir=Directory(maindir=self.maindir,simdir=self.subdir) + self.statistics=Statistics(self.Dir.fullpath(), statfile) + self.Comment=FileContent(os.path.join(self.Dir.fullpath(),".comment")) + pid=self.getPID(); + status=self.getStatus() + if(status==TS_NONEXISTANT or status==TS_NOLOCK): + statustxt="Not running" + pid="" + elif status==TS_STOPPED: + statustxt="Stopped" + else: + statustxt="Running" + + if(self.statistics.fileOK): + report=[time.strftime('%Y-%m-%d %H:%M:%S', time.localtime(int(self.statistics.startDate))),str(datetime.timedelta(microseconds=(int(self.tape.config['iterations'])-int(self.statistics.last))*self.statistics.dT)*1000000), statustxt, pid, str(self.Dir.fullpath()), self.Comment.getText()] + else: + report=["N/A","N/A\t",statustxt, pid, str(self.Dir.fullpath()), self.Comment.getText()] + return report + + def writeComment(self, data, mode='w'): + self.Dir=Directory(maindir=self.maindir,simdir=self.subdir) + self.Comment=FileContent(os.path.join(self.Dir.fullpath(),".comment")) + self.Comment.writefile(data,mode=mode) def __str__(self): if(self.getStatus()==0): -- Gitblit v1.9.3