From 7010269f3bc74c764f5b4e9c72dd069ce34fb244 Mon Sep 17 00:00:00 2001 From: Samo Penic <samo@altea> Date: Wed, 18 May 2016 17:56:30 +0000 Subject: [PATCH] Fix in memory leak. There were also leaks in the old code probably. --- python/trisurf/trisurf.py | 32 ++++++++++++++++++++++---------- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/python/trisurf/trisurf.py b/python/trisurf/trisurf.py index 4387659..310b4d3 100644 --- a/python/trisurf/trisurf.py +++ b/python/trisurf/trisurf.py @@ -199,13 +199,18 @@ Internal method for determining the number of the lines in the most efficient way. Is it really the most efficient? ''' f = open(self.fullname, "r+") - buf = mmap.mmap(f.fileno(), 0) - lines = 0 - readline = buf.readline - while readline(): - lines += 1 + try: + buf = mmap.mmap(f.fileno(), 0) + lines = 0 + readline = buf.readline + while readline(): + lines += 1 + f.close() + except: + lines=0 + f.close() return lines - + def read(self): ''' Method read() reads the statistics if it exists. It sets local variable dT storing the time differential between two intervals of simulation (outer loops). It also stores last simulation loop and the start of the run. @@ -324,8 +329,15 @@ return TS_NOLOCK if(psutil.pid_exists(int(pid))): proc= psutil.Process(int(pid)) - if proc.name()=="trisurf": - if proc.status()=="stopped": + #psutil.__version__ == '3.4.2' requires name() and status(), some older versions reguire name, status + if(psutil.__version__>='2.0.0'): + procname=proc.name() + procstat=proc.status() + else: + procname=proc.name + procstat=proc.status + if procname=="trisurf": + if procstat=="stopped": return TS_STOPPED else: return TS_RUNNING @@ -358,7 +370,7 @@ print("Error -- cannot make tapefile "+ os.path.join(self.Dir.fullpath(),"tape")+" from the snapshot in the running directory") exit(1) try: - os.symlink(os.path.abspath(self.snapshotFile), os.path.join(self.Dir.fullpath(),self.snapshotFile)) + os.symlink(os.path.abspath(self.snapshotFile), os.path.join(self.Dir.fullpath(),"initial_snapshot.vtu")) except: print("Error while symlinking "+os.path.abspath(self.snapshotFile)+" to "+os.path.join(self.Dir.fullpath(),self.snapshotFile)) @@ -371,7 +383,7 @@ self.Dir.goto() print("Starting trisurf-ng executable in "+self.Dir.fullpath()) if(self.fromSnapshot==True): - params=["trisurf", "--restore-from-vtk",self.snapshotFile]+self.runArgs + params=["trisurf", "--restore-from-vtk","initial_snapshot.vtu"]+self.runArgs else: #veify if dump exists. If not it is a first run and shoud be run with --force-from-tape if(os.path.isfile("dump.bin")==False): -- Gitblit v1.9.3