From 6fa0c93a432b95a6b888882494fcafb11c41515c Mon Sep 17 00:00:00 2001
From: Samo Penic <samo.penic@gmail.com>
Date: Sat, 30 Nov 2013 10:55:53 +0000
Subject: [PATCH] finished rewritting. start debugging
---
src/vertex.c | 148 ++++++++++++++++++++++++++----------------------
1 files changed, 80 insertions(+), 68 deletions(-)
diff --git a/src/vertex.c b/src/vertex.c
index 4a6aeb9..653d8d2 100644
--- a/src/vertex.c
+++ b/src/vertex.c
@@ -8,12 +8,11 @@
ts_vertex_list *init_vertex_list(ts_uint N){
ts_int i;
- ts_vertex_list *vlist=(ts_vertex_list *)malloc(sizeof(ts_vertex_list));
-
+ ts_vertex_list *vlist=(ts_vertex_list *)calloc(1,sizeof(ts_vertex_list));
+
if(N==0){
- err("Initialized vertex list with zero elements. Pointer set to NULL");
- vlist->n=0;
- vlist->vtx=NULL;
+ vlist->n=0;
+ vlist->vtx=(ts_vertex **)calloc(1,sizeof(ts_vertex *)); /*Allocate one memory space for vlist anyway */
return vlist;
}
@@ -23,73 +22,54 @@
for(i=0;i<N;i++) {
vlist->vtx[i]=(ts_vertex *)calloc(1,sizeof(ts_vertex));
vlist->vtx[i]->idx=i;
- }
+ /* initialize Ylm for spherical hamonics DONE in sh.c */
+ }
vlist->n=N;
return vlist;
}
-ts_bool vtx_add_neighbour(ts_vertex *vtx, ts_vertex *nvtx){
- ts_uint i;
- /* no neighbour can be null! */
- if(vtx==NULL || nvtx==NULL) return TS_FAIL;
-
- /*if it is already a neighbour don't add it to the list */
- for(i=0; i<vtx->neigh_no;i++){
- if(vtx->neigh[i]==nvtx) return TS_FAIL;
- }
- ts_uint nn=++vtx->neigh_no;
- vtx->neigh=(ts_vertex **)realloc(vtx->neigh, nn*sizeof(ts_vertex *));
- vtx->neigh[nn-1]=nvtx;
-/* This was a bug in creating DIPYRAMID (the neighbours were not in right
- * order).
- */
- /* pa se sosedu dodamo vertex */
- /*if it is already a neighbour don't add it to the list */
-/*
- for(i=0; i<nvtx->data->neigh_no;i++){
- if(nvtx->data->neigh[i]==vtx) return TS_FAIL;
- }
- nn=++nvtx->data->neigh_no;
- nvtx->data->neigh=(ts_vertex **)realloc(nvtx->data->neigh, nn*sizeof(ts_vertex *));
- nvtx->data->neigh[nn-1]=vtx;
-*/
- return TS_SUCCESS;
+ts_bool vertex_list_add_vtx(ts_vertex_list *vlist, ts_vertex *vtx){
+
+#ifdef DEBUG
+ if(vtx==NULL || vlist==NULL) return TS_FAIL;
+#endif
+ if(vlist->list_size < vlist->n+1){
+ vlist->vtx=(ts_vertex **)realloc(vlist->vtx, (vlist->list_size+TS_VLIST_CHUNK)*sizeof(ts_vertex*));
+ if(vlist->vtx==NULL){
+ fatal("Error in vertex_list_add. Could not reallocate memory space.",9999);
+ }
+ vlist->list_size+=TS_VLIST_CHUNK;
+ }
+ vlist->vtx[vlist->n]=vtx;
+ vlist->n++;
+ return TS_SUCCESS;
}
-/* TODO: optimize this. test this. */
-ts_bool vtx_remove_neighbour(ts_vertex *vtx, ts_vertex *nvtx){
-/* find a neighbour */
-/* remove it from the list while shifting remaining neighbours up */
- ts_uint i,j=0;
- for(i=0;i<vtx->neigh_no;i++){
- if(vtx->neigh[i]!=nvtx){
- vtx->neigh[j]=vtx->neigh[i];
- j++;
- }
- }
-/* resize memory. potentionally time consuming */
- vtx->neigh_no--;
- vtx->neigh=(ts_vertex **)realloc(vtx->neigh,vtx->neigh_no*sizeof(ts_vertex *));
- if(vtx->neigh == NULL && vtx->neigh_no!=0)
- fatal("Reallocation of memory failed during removal of vertex neighbour in vtx_remove_neighbour",100);
-/* repeat for the neighbour */
-/* find a neighbour */
-/* remove it from the list while shifting remaining neighbours up */
- for(i=0;i<nvtx->neigh_no;i++){
- if(nvtx->neigh[i]!=vtx){
- nvtx->neigh[j]=nvtx->neigh[i];
- j++;
- }
- }
-/* resize memory. potentionally time consuming. */
- nvtx->neigh_no--;
- nvtx->neigh=(ts_vertex **)realloc(nvtx->neigh,nvtx->neigh_no*sizeof(ts_vertex *));
- if(nvtx->neigh == NULL && nvtx->neigh_no!=0)
- fatal("Reallocation of memory failed during removal of vertex neighbour in vtx_remove_neighbour",100);
-
- return TS_SUCCESS;
+/* Idea is to delete vertex by removing it from list. The emply place is then filled in by the last
+vertex in the list. List can then be resized by one -- unless resize is required when max list size -
+real list size > predefined value */
+ts_bool vertex_list_remove_vtx(ts_vertex_list *vlist, ts_vertex *vtx){
+#ifdef DEBUG
+ if(vtx==NULL || vlist==NULL) return TS_FAIL;
+#endif
+ ts_uint i;
+ for(i=0; i<vlist->n;i++){
+ if(vlist->vtx[i]==vtx){
+ vlist->vtx[i]=vlist->vtx[vlist->n-1];
+ vlist->n--;
+ if(vlist->list_size-vlist->n > TS_VLIST_CHUNK){
+ vlist->vtx=(ts_vertex **)realloc(vlist->vtx, (vlist->list_size-TS_VLIST_CHUNK)*sizeof(ts_vertex*));
+ if(vlist->vtx==NULL){
+ fatal("Error in vertex_list_add. Could not reallocate memory space.",9999);
+ }
+ vlist->list_size-=TS_VLIST_CHUNK;
+ }
+ return TS_SUCCESS;
+ }
+ }
+ return TS_FAIL;
}
@@ -99,20 +79,32 @@
bond=bond_add(blist,vtx1,vtx2);
if(bond==NULL) return TS_FAIL;
vtx1->bond_no++;
+ vtx2->bond_no++;
// vtx2->data->bond_no++;
vtx1->bond=(ts_bond **)realloc(vtx1->bond, vtx1->bond_no*sizeof(ts_bond *));
+ vtx2->bond=(ts_bond **)realloc(vtx2->bond, vtx2->bond_no*sizeof(ts_bond *));
// vtx2->data->bond=(ts_bond **)realloc(vtx2->data->bond, vtx2->data->bond_no*sizeof(ts_bond *));
vtx1->bond[vtx1->bond_no-1]=bond;
+ vtx2->bond[vtx2->bond_no-1]=bond;
// vtx2->ata->bond[vtx2->data->bond_no-1]=bond;
return TS_SUCCESS;
}
+
+ts_bool vtx_add_neighbour(ts_vertex *vtx1, ts_vertex *vtx2){
+ vertex_list_add_vtx(vtx1->neigh, vtx2);
+ vertex_list_add_vtx(vtx2->neigh, vtx1);
+ return TS_SUCCESS;
+}
+
ts_bool vtx_add_cneighbour(ts_bond_list *blist, ts_vertex *vtx1, ts_vertex *vtx2){
ts_bool retval;
- retval=vtx_add_neighbour(vtx1,vtx2);
+ retval=vertex_list_add_vtx(vtx1->neigh, vtx2);
+ retval=vertex_list_add_vtx(vtx2->neigh, vtx1);
if(retval==TS_SUCCESS)
- retval=vtx_add_bond(blist,vtx1,vtx2);
+ retval=vtx_add_bond(blist,vtx1,vtx2);
+
return retval;
}
@@ -131,7 +123,6 @@
if(vtx->neigh!=NULL) free(vtx->neigh);
if(vtx->tristar!=NULL) free(vtx->tristar);
if(vtx->bond!=NULL) free(vtx->bond);
-
free(vtx);
return TS_SUCCESS;
}
@@ -197,6 +188,28 @@
}
+
+/* vtx remove tristar is required in bondflip. */
+/* TODO: Check whether it is important to keep the numbering of tristar
+ * elements in some order or not! */
+inline ts_bool vtx_remove_tristar(ts_vertex *vtx, ts_triangle *tristar){
+ ts_uint i,j=0;
+ for(i=0;i<vtx->tristar_no;i++){
+ if(vtx->tristar[i]!=tristar){
+ vtx->tristar[j]=vtx->tristar[i];
+ j++;
+ }
+ }
+ vtx->tristar_no--;
+ vtx->tristar=realloc(vtx->tristar,vtx->tristar_no*sizeof(ts_triangle *));
+ if(vtx->neigh == NULL){
+ fatal("Reallocation of memory failed during insertion of vertex neighbour in vertex_add_neighbour",3);
+ }
+ return TS_SUCCESS;
+}
+
+
+
/* ****************************************************************** */
/* ***** New vertex copy operations. Inherently they are slow. ***** */
/* ****************************************************************** */
@@ -204,7 +217,6 @@
ts_bool vtx_copy(ts_vertex *cvtx, ts_vertex *ovtx){
memcpy((void *)cvtx,(void *)ovtx,sizeof(ts_vertex));
cvtx->neigh=NULL;
- cvtx->neigh_no=0;
cvtx->tristar_no=0;
cvtx->bond_no=0;
cvtx->tristar=NULL;
--
Gitblit v1.9.3